Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test:Fix leaky tracer setting #1118

Merged
merged 1 commit into from
Jul 24, 2020
Merged

test:Fix leaky tracer setting #1118

merged 1 commit into from
Jul 24, 2020

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Jul 24, 2020

We were disabling the tracer for a environment_logger_spec.rb, but never re-enabling it.
This could cause subsequent tests to fail, like this one: https://app.circleci.com/pipelines/github/DataDog/dd-trace-rb/1563/workflows/080116a3-5a99-45ca-a4ec-3fe67c657cb0/jobs/77623

@marcotc marcotc added the dev/testing Involves testing processes (e.g. RSpec) label Jul 24, 2020
@marcotc marcotc requested a review from a team July 24, 2020 19:10
@marcotc marcotc self-assigned this Jul 24, 2020
@marcotc marcotc merged commit 5e0b79d into master Jul 24, 2020
@marcotc marcotc added this to the 0.39.0 milestone Jul 24, 2020
@marcotc marcotc deleted the test/fix-leaky-config-test branch July 28, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants