Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs:Clear wording for :orm_service_name setting #1119

Merged
merged 1 commit into from
Jul 24, 2020
Merged

docs:Clear wording for :orm_service_name setting #1119

merged 1 commit into from
Jul 24, 2020

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Jul 24, 2020

This PR address the wording on ActiveRecord's orm_service_name option, to make it clear that it refers to the Ruby object instantiation portion of ActiveRecord queries.

@marcotc marcotc added the docs Involves documentation label Jul 24, 2020
@marcotc marcotc requested a review from a team July 24, 2020 20:29
@marcotc marcotc self-assigned this Jul 24, 2020
@marcotc
Copy link
Member Author

marcotc commented Jul 24, 2020

I received @andrewardito's verbal seal of approval on this one 😄

@marcotc marcotc merged commit 5721a25 into master Jul 24, 2020
@marcotc marcotc deleted the docs/orm-clarificatin branch July 24, 2020 21:20
@marcotc marcotc added this to the 0.39.0 milestone Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettlangdon brettlangdon brettlangdon approved these changes

Assignees

@marcotc marcotc

Labels
docs Involves documentation
Projects
None yet
Milestone
0.39.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marcotc @brettlangdon