Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Integrate Sneakers into ddtracer #1121

Merged
merged 2 commits into from
Jul 30, 2020
Merged

feat: Integrate Sneakers into ddtracer #1121

merged 2 commits into from
Jul 30, 2020

Conversation

janz93
Copy link

@janz93 janz93 commented Jul 27, 2020

With the version 2.12.0 sneakers added a middleware concept which
makes it possible to hook onto in order to send automatically traces to Datadog

closes #1114

@janz93 janz93 requested a review from a team July 27, 2020 13:43
@janz93
Copy link
Author

janz93 commented Jul 27, 2020

Screenshot 2020-07-27 at 15 45 34

Copy link
Member

@marcotc marcotc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @janz93, awesome job on this PR, pretty much ready to merge!
I left one suggested changed, let me know if it makes sense to address it.

lib/ddtrace/contrib/sneakers/tracer.rb Outdated Show resolved Hide resolved
@marcotc marcotc added community Was opened by a community member feature Involves a product feature labels Jul 27, 2020
@marcotc
Copy link
Member

marcotc commented Jul 27, 2020

(BTW, your CI failure should be fixed if you rebase with latest master)

Copy link
Contributor

@ericmustin ericmustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few small changes but overall great work here!

lib/ddtrace/contrib/sneakers/ext.rb Outdated Show resolved Hide resolved
ericmustin and others added 2 commits July 29, 2020 10:42
Co-authored-by: Marco Costa <marco.costa@datadoghq.com>
With the version *2.12.0* sneakers added a middleware concept which
makes it possible to hook onto in order to send automatically traces to Datadog
Copy link
Member

@marcotc marcotc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @janz93!

@marcotc marcotc dismissed ericmustin’s stale review July 30, 2020 16:02

Changes were addressed.

@marcotc marcotc merged commit 63b1dc9 into DataDog:master Jul 30, 2020
@marcotc marcotc added this to the 0.39.0 milestone Jul 30, 2020
@janz93 janz93 deleted the sneakers branch July 31, 2020 09:21
@janz93
Copy link
Author

janz93 commented Jul 31, 2020

@marcotc Thank you for the tip with the rebase I was a little bit puzzled once the CI broke at this random spot
@ericmustin Thanks for the conversation and explanation around the options

This was a very nice experience :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Was opened by a community member feature Involves a product feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracing for sneakers
3 participants