-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Integrate Sneakers into ddtracer #1121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @janz93, awesome job on this PR, pretty much ready to merge!
I left one suggested changed, let me know if it makes sense to address it.
(BTW, your CI failure should be fixed if you rebase with latest master) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few small changes but overall great work here!
Co-authored-by: Marco Costa <marco.costa@datadoghq.com>
With the version *2.12.0* sneakers added a middleware concept which makes it possible to hook onto in order to send automatically traces to Datadog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much @janz93!
@marcotc Thank you for the tip with the rebase I was a little bit puzzled once the CI broke at this random spot This was a very nice experience :) |
With the version 2.12.0 sneakers added a middleware concept which
makes it possible to hook onto in order to send automatically traces to Datadog
closes #1114