migrate pipeline processor and filter tests to rspec #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotc
requested changes
Aug 4, 2020
spec/ddtrace/pipeline_spec.rb
Outdated
Comment on lines
20
to
22
|
|
||
| before do | ||
| end |
Comment on lines
6
to
11
| def generate_span(name, parent = nil) | ||
| Datadog::Span.new(nil, name).tap do |span| | ||
| span.parent = parent | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
You might want to move this method in to a shared file, like Sidekiq does here: https://github.com/DataDog/dd-trace-rb/tree/64ec7458bd9e6fe010382cdd655044a8aca7264f/spec/ddtrace/contrib/sidekiq/support
We normally add a support/ directory with shared files in it.
There was a problem hiding this comment.
makes sense, updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves over the
Datadog::Pipeline,Datadog::Pipeline::SpanProcessor, andDatadog::Pipeline::SpanFilterminitest tests within the /tests folder to rspec spec's within the /spec folder. It tests what was covered in the minitest suite, specifically, the behavior of the trace pipeline, and the functionality of both OOTB processor and filter classes as well as arbitrary processors or filters as described here: https://github.com/DataDog/dd-trace-rb/blob/master/docs/GettingStarted.md#processing-pipeline