Add a single top level span for Racecar consumers #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, Racecar consumer processes use one of two top level span names based on the mode of operation: `racecar.message` or `racecar.batch`. Because of this, the Datadog interface cannot show single message consumers and batch consumers in the same list. This change subscribes to the `main_loop` event which wraps both of these more specific events. The new span is called `racecar.consume` since that is the logical operation.
|
Hey @dasch, the changes look like a straightforward improvement, thank you! One think I'd like to ask for you is the additional of tests for this new span, similar to what we have today for |
marcotc
added
community
dasch
force-pushed
the
dasch-racecar-single-toplevel-span
branch
from
82e0b5a
to
3b16692
Compare
marcotc
approved these changes
Aug 21, 2020
Thank you very much 
|
@marcotc should be ready to go 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, Racecar consumer processes use one of two top level span names based on the mode of operation:
racecar.messageorracecar.batch. Because of this, the Datadog interface cannot show single message consumers and batch consumers in the same list.This change subscribes to the
main_loopevent which wraps both of these more specific events. The new span is calledracecar.consumesince that is the logical operation.