Ensure OpenTracer test does not leak writer thread #1163
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this CI issue:
This error happens because the OpenTracing test was not properly closing the worker thread crated by its write, causing it to interfere with subsequent test runs. This PR fixes that by properly shutting down the tracer after each run.
This error can be reproduced with the following command:
bundle exec rspec ./spec/ddtrace/opentracer/propagation_integration_spec.rb --seed=42061
You might have to run it a few times to it to fail.