Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend delayed_job plugin #1187

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

norbertnytko
Copy link
Contributor

@norbertnytko norbertnytko commented Sep 28, 2020

It would be great to monitor delayed_job enqueues in case of any errors or latency related to those events.

Example usage:

Datadog.configure do |c|
  c.use :delayed_job, {
    service_name: "some_service_name-delayed_job",
    client_service_name: "some_service_name-delayed_job-client",
    analytics_enabled: true,
  }
end

@norbertnytko norbertnytko requested a review from a team September 28, 2020 09:48
marcotc
marcotc previously approved these changes Sep 29, 2020
Copy link
Member

@marcotc marcotc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, @norbertnytko! The PR looks good. 🚀

@marcotc
Copy link
Member

marcotc commented Sep 29, 2020

@norbertnytko I noticed you are based off an older branch of the tracer. Could you please rebase it with master instead?

Out of curiosity, we used to guide contributors to base their changes off the latest X.Y-dev branch, which I believe is what you did here. We have since removed that recommendation from our guides. Did you base you changes off 0.28-dev because you found instructions telling you to do such?

@norbertnytko norbertnytko changed the base branch from 0.28-dev to master September 30, 2020 09:47
@norbertnytko norbertnytko dismissed marcotc’s stale review September 30, 2020 09:47

The base branch was changed.

@norbertnytko
Copy link
Contributor Author

@marcotc rebased
Exactly, CONTRIBUTING.md

@marcotc marcotc added community Was opened by a community member integrations Involves tracing integrations labels Sep 30, 2020
@marcotc marcotc merged commit 5cc4725 into DataDog:master Sep 30, 2020
@marcotc marcotc added this to the 0.42.0 milestone Sep 30, 2020
@ericmustin
Copy link
Contributor

@norbertnytko we've released 0.42.0 with this work, thanks again for the contribution! https://github.com/DataDog/dd-trace-rb/releases/tag/v0.42.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Was opened by a community member integrations Involves tracing integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants