Fix diagnostic debug settings test #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously trying to match on
expect_any_instance_of(Kernel), which is a very blunt matcher that doesn't work reliably: it failed to intercept mocked method calls depending on test execution order.This PR changes that matcher to
expect_any_instance_of(Object), which seems to behave nicely regardless of our execution patterns.Overall,
expect_any_instance_ofhas many corner cases we've stumbled upon recently, and it has proven flaky (RSpec team doesn't recommend it either), but I don't see a better way to thisrequirestatements like in this test.