Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Kafka test in CI #1244

Merged
merged 3 commits into from
Nov 13, 2020
Merged

Run Kafka test in CI #1244

merged 3 commits into from
Nov 13, 2020

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Nov 11, 2020 •
edited

This PR enables ruby-kafka tests to run in CI.
We forgot to enable them when that integration was first implemented.

marcotc and others added 2 commits November 11, 2020 14:06
@marcotc
Enable Kafka testing in CI
166668f
@cjford @marcotc
Fix kafka/patcher_spec.rb
5d7a6a8 
Switch from using get_test_tracer with FauxWriter to newer methods from Contrib::TracerHelpers
@marcotc marcotc mentioned this pull request Nov 11, 2020
Closed
brettlangdon
brettlangdon reviewed Nov 12, 2020
View reviewed changes
Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this mean we were not testing our kafka integration?

@marcotc
Copy link
Member Author

marcotc commented Nov 12, 2020

@brettlangdon correct.

@marcotc marcotc self-assigned this Nov 12, 2020
@marcotc marcotc added dev/testing Involves testing processes (e.g. RSpec) integrations Involves tracing integrations labels Nov 12, 2020
@marcotc marcotc marked this pull request as ready for review November 12, 2020 21:56
@marcotc marcotc requested review from a team and brettlangdon November 12, 2020 21:56
@marcotc
Copy link
Member Author

marcotc commented Nov 12, 2020

Let's ping #1242 when this PR is merged, so we can unblock that PR.

@marcotc marcotc merged commit 61414f0 into master Nov 13, 2020
@marcotc marcotc deleted the test/add-kafka-ci branch November 13, 2020 16:56
@marcotc marcotc added this to the 0.43.0 milestone Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericmustin ericmustin ericmustin approved these changes

@brettlangdon brettlangdon Awaiting requested review from brettlangdon

Assignees

@marcotc marcotc

Labels
dev/testing Involves testing processes (e.g. RSpec) integrations Involves tracing integrations
Projects
None yet
Milestone
0.43.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marcotc @brettlangdon @ericmustin @cjford