Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Runtime Metrics frequency to every 10 seconds #1269

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Dec 1, 2020

This PR reduces the Runtime Metrics (thread count, global class count, and GC statistics) reporting frequency from every second to every 10 seconds.

Reporting of these values in such fine granularity has a measurable cost, but don't provide enough value to justify the current resolution. Most reporting done across the data collected here span throughout the lifetime of the host application, which can require minutes to hours of data to provide meaningful results.

Additionally, because of the introduction of a new integration tests in this PR, I've also added an Integration Test helper, to allow for easily tagging integration tests and have them only run when appropriate, given their high execution cost.

@marcotc marcotc added the core Involves Datadog core libraries label Dec 1, 2020
@marcotc marcotc self-assigned this Dec 1, 2020
@marcotc marcotc requested a review from a team December 1, 2020 21:57
Copy link
Contributor

@ericmustin ericmustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, we might be introducing a breaking change to folks metrics dashboard though, as previously i'd assume there was some aggregation occurring that could have changed the value slightly, so we want to document this imo.

@marcotc
Copy link
Member Author

marcotc commented Dec 2, 2020

as previously i'd assume there was some aggregation occurring that could have changed the value slightly

I don't expect any material changes, as our dashboard graph resolution is 20 seconds today. Visually in UI graphs, I expect no significant change.

But I agree we should make it clear in the changelog that this change is going out.

@marcotc marcotc merged commit d5f85d7 into master Dec 2, 2020
@marcotc marcotc deleted the reduce-runtime-metrics-frequency branch December 2, 2020 20:32
@github-actions github-actions bot added this to the 0.44.0 milestone Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Involves Datadog core libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants