Fix negative assertion for custom span error matching #1293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the negative matching case for our custom error matchers, e.g.
have_error_message
matcher (is_expected.to_not have_error_message
).There was one test that had an incorrect assertion:
http.rb
dd-trace-rb/spec/ddtrace/contrib/httprb/instrumentation_spec.rb
Lines 152 to 154 in 774ee8e
This assertion is for the 404 case, which by default is considered an error by our integration. The tracer itself is correctly recording this error, but the test was broke, and was actually asserting that there was no error.