Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix negative assertion for custom span error matching #1293

Merged
merged 1 commit into from
Dec 22, 2020

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Dec 21, 2020

This PR fixes the negative matching case for our custom error matchers, e.g. have_error_message matcher (is_expected.to_not have_error_message).

There was one test that had an incorrect assertion: http.rb

it 'has no error set' do
expect(span).to_not have_error_message
end

This assertion is for the 404 case, which by default is considered an error by our integration. The tracer itself is correctly recording this error, but the test was broke, and was actually asserting that there was no error.

@marcotc marcotc added the dev/testing Involves testing processes (e.g. RSpec) label Dec 21, 2020
@marcotc marcotc self-assigned this Dec 21, 2020
@marcotc marcotc requested a review from a team December 21, 2020 22:36
@marcotc marcotc merged commit 1f8551c into master Dec 22, 2020
@github-actions github-actions bot added this to the 0.44.0 milestone Dec 22, 2020
@marcotc marcotc deleted the fix-httprb-test branch April 27, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants