Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GettingStarted.md #1297

Merged
merged 3 commits into from
Jan 5, 2021
Merged

Update GettingStarted.md #1297

merged 3 commits into from
Jan 5, 2021

Conversation

andrewardito
Copy link
Contributor

Add Agent setup to Ruby getting started docs

Add Agent setup to Ruby getting started docs
@andrewardito andrewardito requested a review from a team January 5, 2021 15:44
Copy link
Contributor

@ericmustin ericmustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewardito I think we need to rip out all the java stuff here, also i'm not sure if the templating stuff {{ }} displays properly in markdown

@andrewardito
Copy link
Contributor Author

@andrewardito I think we need to rip out all the java stuff here, also i'm not sure if the templating stuff {{ }} displays properly in markdown

Oh I'm blind sorry, will remove Java.

ericmustin
ericmustin previously approved these changes Jan 5, 2021
Copy link
Contributor

@ericmustin ericmustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-io
Copy link

Codecov Report

Merging #1297 (f367ec9) into master (98ffbea) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1297   +/-   ##
=======================================
  Coverage   97.88%   97.88%           
=======================================
  Files         752      752           
  Lines       35870    35870           
=======================================
  Hits        35111    35111           
  Misses        759      759           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98ffbea...f367ec9. Read the comment docs.

@marcotc marcotc merged commit ceadd55 into master Jan 5, 2021
@marcotc marcotc deleted the andrewardito-patch-2 branch January 5, 2021 17:27
@github-actions github-actions bot added this to the 0.44.0 milestone Jan 5, 2021
@marcotc marcotc added the docs Involves documentation label Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Involves documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants