Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memoize URI to cut down multiple parsing #1302

Merged
merged 2 commits into from
Jan 7, 2021
Merged

Memoize URI to cut down multiple parsing #1302

merged 2 commits into from
Jan 7, 2021

Conversation

callumj
Copy link
Contributor

@callumj callumj commented Jan 7, 2021 •
edited

I've noticed that datadog_tag_request makes multiple calls to uri but because it isn't memoized we're re-parsing it 3 times.

@callumj callumj requested a review from a team January 7, 2021 05:19
@codecov-io
Copy link

Codecov Report

Merging #1302 (3030110) into master (e796c93) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1302   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files         752      752           
  Lines       35740    35741    +1     
=======================================
+ Hits        35074    35075    +1     
  Misses        666      666
Impacted Files Coverage Δ
lib/ddtrace/contrib/ethon/easy_patch.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e796c93...3030110. Read the comment docs.

ericmustin
ericmustin approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@ericmustin ericmustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for the PR @callumj

@marcotc marcotc merged commit 4c0d5e9 into DataDog:master Jan 7, 2021
@github-actions github-actions bot added this to the 0.45.0 milestone Jan 7, 2021
@marcotc marcotc added community Was opened by a community member integrations Involves tracing integrations performance Involves performance (e.g. CPU, memory, etc) labels Jan 7, 2021
@marcotc
Copy link
Member

marcotc commented Jan 27, 2021

👋 @callumj, we've just released v0.45.0, which includes this PR.

Thank you again, @callumj! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericmustin ericmustin ericmustin approved these changes

Assignees
No one assigned
Labels
community Was opened by a community member integrations Involves tracing integrations performance Involves performance (e.g. CPU, memory, etc)
Projects
None yet
Milestone
0.45.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@callumj @codecov-io @marcotc @ericmustin