More defensive distributed HTTP propagator #1304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a "begin/rescue" block around
HTTPPropagator
extractors and injectors. This should catch any issues that could arise for any propagator implementations, specially useful for custom propagators.This ensures that
HTTPPropagator.inject!
andHTTPPropagator.extract
never fail.An error is logged to
Datadog.logger
if any error occurs in the propagators.