Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DeprecatedPin #1342

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Remove DeprecatedPin #1342

merged 1 commit into from
Feb 3, 2021

Conversation

delner
Copy link
Contributor

@delner delner commented Feb 2, 2021

DeprecatedPin was introduced on a few integrations to aid the transition from use of datadog_pin to c.use :integration via #692. It's nearly 2 years old at this point, and should be safe to remove.

@delner delner added core Involves Datadog core libraries dev/refactor Involves refactoring existing components labels Feb 2, 2021
@delner delner self-assigned this Feb 2, 2021
@delner delner force-pushed the refactor/remove_deprecated_pin branch from 50da490 to f1036ec Compare February 2, 2021 20:41
@codecov-io
Copy link

Codecov Report

Merging #1342 (f1036ec) into master (7e6fdb0) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1342      +/-   ##
==========================================
- Coverage   98.06%   98.05%   -0.02%     
==========================================
  Files         765      765              
  Lines       36486    36229     -257     
==========================================
- Hits        35780    35524     -256     
+ Misses        706      705       -1     
Impacted Files Coverage Δ
lib/ddtrace/contrib/dalli/patcher.rb 100.00% <ø> (+3.33%) ⬆️
lib/ddtrace/contrib/faraday/patcher.rb 92.30% <ø> (-0.55%) ⬇️
lib/ddtrace/contrib/grape/patcher.rb 100.00% <ø> (+14.70%) ⬆️
lib/ddtrace/contrib/grpc/patcher.rb 100.00% <ø> (+2.94%) ⬆️
lib/ddtrace/pin.rb 98.00% <ø> (-0.58%) ⬇️
spec/ddtrace/pin_spec.rb 100.00% <ø> (ø)
spec/ddtrace/contrib/dalli/patcher_spec.rb 80.00% <100.00%> (-20.00%) ⬇️
spec/ddtrace/contrib/faraday/patcher_spec.rb 80.00% <100.00%> (-20.00%) ⬇️
spec/ddtrace/contrib/grpc/patcher_spec.rb 80.00% <100.00%> (-20.00%) ⬇️
spec/support/log_helpers.rb 84.00% <0.00%> (-2.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e6fdb0...f1036ec. Read the comment docs.

@delner delner marked this pull request as ready for review February 2, 2021 21:00
@delner delner requested a review from a team February 2, 2021 21:00
Copy link
Member

@marcotc marcotc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@delner delner merged commit 6292ff5 into master Feb 3, 2021
@delner delner deleted the refactor/remove_deprecated_pin branch February 3, 2021 17:08
@github-actions github-actions bot added this to the 0.46.0 milestone Feb 3, 2021
@delner delner added this to Released in Active work Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Involves Datadog core libraries dev/refactor Involves refactoring existing components
Projects
Active work
  
Released
Development

Successfully merging this pull request may close these issues.

None yet

3 participants