Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EventBridge to supported AWS services #1368

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Add EventBridge to supported AWS services #1368

merged 1 commit into from
Feb 19, 2021

Conversation

tomgi
Copy link
Contributor

@tomgi tomgi commented Feb 17, 2021

Hi, I'm using ddtrace AWS integration to be able to track every interaction with AWS services in Datadog.

I've noticed that the calls to EventBridge API seem to be missing though.

I think simply adding EventBridge to the list of supported AWS services should enable that tracking.

aws-sdk-eventbridge gem uses AWS Seahorse Client (like all the other AWS services), so I reckon it should "just work".

I checked that :EventBridge exists in ::Aws.constants, so it won't get filtered out in

available_services = ::Aws.constants & SERVICES.map(&:to_sym)

@tomgi tomgi requested a review from a team February 17, 2021 08:00
Copy link
Member

@marcotc marcotc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, @tomgi! 🎉

@marcotc marcotc merged commit 1e444ed into DataDog:master Feb 19, 2021
@github-actions github-actions bot added this to the 0.46.0 milestone Feb 19, 2021
@tomgi tomgi deleted the patch-1 branch February 24, 2021 01:17
@marcotc
Copy link
Member

marcotc commented Mar 3, 2021

👋 @tomgi, version 0.46.0 has just been released, including this PR.

Thank you so much for you contribution 🙇.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants