[CIAPP-1208] Rework RSpec instrumentation as separate traces for each test #1381
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue on ci-app where we do not expect several spans with
type: test
on the same trace.We discussed two options and went for this:
The instrumentation now only patches
RSpec::Example
and we remove any wrapping onExampleGroup
.This is a new integration only used internally so it should be fine to re-do without backwards compatibility concerns.
I also increased the test coverage to address our concerns not knowing how it would work with the lazy nature of rspec on
let
, and before/after/around hooks.