Use modern pry/pry-byebug on Rubies that support it #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old `pry-nav` is basically abandoned at this point, see <nixme/pry-nav#35> and <nixme/pry-nav#33> and the README points to `pry-byebug`: <https://github.com/nixme/pry-nav#using-mri-we-recommend-pry-byebug-instead>. Because of our usual support matrix of old Rubies, I've kept `pry-nav` around for older versions. I've also added `pry-debugger-jruby`, which is a nicer alternative for JRuby. This setup works correctly for all Rubies: 2.0 to 3.0, JRuby and even TruffleRuby.
ivoanjo
force-pushed
the
ivoanjo/upgrade-pry-and-debugger-gems
branch
from
873b329
to
37fb072
Compare
marcotc
approved these changes
Mar 15, 2021
delner
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old
pry-navis basically abandoned at this point, see nixme/pry-nav#35 and nixme/pry-nav#33 and the README points topry-byebug: https://github.com/nixme/pry-nav#using-mri-we-recommend-pry-byebug-instead.Because of our usual support matrix of old Rubies, I've kept
pry-navaround for older versions.I've also added
pry-debugger-jruby, which is a nicer alternative for JRuby.This setup works correctly for all Rubies: 2.0 to 3.0, JRuby and even TruffleRuby.