Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Schemas to supported AWS services #1415

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Add Schemas to supported AWS services #1415

merged 1 commit into from
Mar 18, 2021

Conversation

tomgi
Copy link
Contributor

@tomgi tomgi commented Mar 18, 2021

Hi, I'm using ddtrace AWS integration to be able to track every interaction with AWS services in Datadog.

I've noticed that the calls to Schemas API seem to be missing though.

I think simply adding Schemas to the list of supported AWS services should enable that tracking.

aws-sdk-schemas gem uses AWS Seahorse Client (like all the other AWS services), so I reckon it should "just work".

I checked that :Schemas exists in ::Aws.constants, so it won't get filtered out in

available_services = ::Aws.constants & SERVICES.map(&:to_sym)

@tomgi tomgi requested a review from a team March 18, 2021 03:38
Copy link
Member

@marcotc marcotc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tomgi! 🙇

@marcotc marcotc merged commit 39441ae into DataDog:master Mar 18, 2021
@marcotc marcotc added the integrations Involves tracing integrations label Mar 18, 2021
@github-actions github-actions bot added this to the 0.47.0 milestone Mar 18, 2021
@marcotc
Copy link
Member

marcotc commented Mar 29, 2021

👋 @tomgi, thank you again for your contribution! These changes have just been released in v0.47.0.

@tomgi tomgi deleted the patch-1 branch March 30, 2021 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Involves tracing integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants