Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint changes for latest Rubocop minor release #1430

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Lint changes for latest Rubocop minor release #1430

merged 1 commit into from
Mar 25, 2021

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Mar 25, 2021

Makes CI green, alongside #1429

Rubocop recently changed the existing Style/RedundantBegin cop to identify additional cases.

This PR addresses the newly discovered infractors and addresses them.

@marcotc marcotc added the dev/refactor Involves refactoring existing components label Mar 25, 2021
@marcotc marcotc self-assigned this Mar 25, 2021
@marcotc marcotc requested a review from a team March 25, 2021 21:31
Copy link
Contributor

@ericmustin ericmustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👮‍♂️

@marcotc marcotc merged commit f9ac255 into master Mar 25, 2021
@marcotc marcotc deleted the lint-rubocop branch March 25, 2021 21:48
@github-actions github-actions bot added this to the 0.47.0 milestone Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/refactor Involves refactoring existing components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants