Migrate error_test to RSpec #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivoanjo
reviewed
Apr 9, 2021
Comment on lines
+57
to
+59
| # RSpec 'double' hijacks the #class method, thus not allowing us | ||
| # to organically test the `Error#type` inferred for this object. | ||
| clazz = stub_const('Test::CustomMessage', Struct.new(:message)) |
There was a problem hiding this comment.
Minor: You can always define a regular class somewhere :)
ivoanjo
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm planning on making changes to
error.rb, but its tests are in in minitest.