Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove conditional checks for Process.clock_gettime #1524

Merged
merged 2 commits into from
May 27, 2021

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented May 26, 2021

Process.clock_gettime is now available for all supported versions of Ruby.
This PR removes conditional checks for its presence.

Ruby 2.0 deprecation checklist

  • Remove 2.0 from CI
  • Remove 2.0-specific code paths
  • Update to 2.1+ standards: https://github.com/ruby/ruby/blob/v2_1_0/NEWS
    • Module#include and Module#prepend are now public methods.
    • Exception#cause (no changes)
    • Array#to_h converts an array of key-value pairs into a Hash.
    • Kernel#singleton_method (no changes)
    • Process.clock_gettime
    • Enumerable#to_h converts a list of key-value pairs into a Hash.
    • Now the default values of keyword arguments can be omitted. Those “required keyword arguments” need giving explicitly at the call time.
  • Update documentation

@marcotc marcotc added the deprecation Involves a deprecation label May 26, 2021
@marcotc marcotc self-assigned this May 26, 2021
@marcotc marcotc requested a review from a team May 26, 2021 23:10
ivoanjo
ivoanjo previously approved these changes May 27, 2021
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much, kind sir! :)

@marcotc marcotc merged commit 53ba613 into master May 27, 2021
@marcotc marcotc deleted the deprecate-ruby-2.0-clock_gettime branch May 27, 2021 17:56
@github-actions github-actions bot added this to the 0.50.0 milestone May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Involves a deprecation
Projects
Active work
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants