Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare EOL for Ruby 2.0 support #1534

Merged
merged 2 commits into from
Jun 7, 2021
Merged

Declare EOL for Ruby 2.0 support #1534

merged 2 commits into from
Jun 7, 2021

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented May 31, 2021

This PR updates the minimum Ruby version in our gemspec, as well the official documentation with the remove of support for Ruby 2.0.

Ruby 2.1 is the new minimum Ruby version supported.

@marcotc marcotc added docs Involves documentation deprecation Involves a deprecation labels May 31, 2021
@marcotc marcotc added this to the 0.50.0 milestone May 31, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1534 (5eaf8ff) into master (b05fddf) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1534      +/-   ##
==========================================
- Coverage   98.23%   98.23%   -0.01%     
==========================================
  Files         877      877              
  Lines       42261    42261              
==========================================
- Hits        41517    41516       -1     
- Misses        744      745       +1     
Impacted Files Coverage Δ
lib/ddtrace/profiling/collectors/stack.rb 97.93% <0.00%> (-1.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b05fddf...5eaf8ff. Read the comment docs.

ericmustin
ericmustin previously approved these changes Jun 3, 2021
Copy link
Contributor

@ericmustin ericmustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good whenever we want to move out of drafts

@marcotc marcotc marked this pull request as ready for review June 7, 2021 19:13
@marcotc marcotc requested a review from a team June 7, 2021 19:13
@marcotc marcotc self-assigned this Jun 7, 2021
Copy link
Contributor

@ericmustin ericmustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericmustin ericmustin merged commit 80f09f4 into master Jun 7, 2021
@ericmustin ericmustin deleted the deprecate-2.0-docs branch June 7, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Involves a deprecation docs Involves documentation
Projects
Active work
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

3 participants