[PROF-2720] Remove automatic agentless support #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the integration environment does not have a `DD_API_KEY` usually set, these tests were actually never running. I've fixed the tests, as well as refactored them to: * Make sure that transport construction is tested, even if then later the test doesn't run (to allow us to catch issues in transport creation earlier) * Run the reporting to agent test even when the agentless test can't run. Reporting to agent is our primary use case, so we definitely should test it! Agentless is mostly irrelevant, so it's ok if it's not running in the default setup for the integration environment.
The `agent_settings` is allowed to be `nil` whenever the agentless configuration is used, but let's make it clearer that the default/expected path is not to use agentless, and force callers to pass in `agent_settings: nil`, rather than using that as a default. I've also refactored the tests to reflect that this is the primary usecase.
The profiler supports reporting profiling data directly to the datadog backend, without having to go through an agent. This setup is actively discouraged by the profiling team for users, but hey, it is really handy for testing and prototyping. But we don't want users to accidentally enable this mode. Up until now, profiler would implicitly use this mode if users set a `DD_API_KEY` and a `DD_SITE` configuration. Now, this mode will only be enabled if a `DD_PROFILING_AGENTLESS` environment variable is set to `true`.
ivoanjo
commented
Jul 13, 2021
| @@ -4,6 +4,8 @@ module Core | |||
| module Environment | |||
| # Defines helper methods for environment | |||
| module VariableHelpers | |||
| extend self | |||
There was a problem hiding this comment.
Note: This enables use of the module helpers without needing to include the module.
This test is a little too integration-y: we already have quite a few other tests that validate agentless mode, so no need to have this one as well.
Oops! We were actually using a really legacy agent for CI testing, which did not match the version in docker-compose.yml. This explains why a profiler integration test was failing in CircleCI but not in local testing: in CircleCI we were using an agent version so old that it did not have profiling support!
(We don't yet support profiling JRuby)
Codecov Report
@@ Coverage Diff @@
## master #1590 +/- ##
=======================================
Coverage 98.26% 98.27%
=======================================
Files 896 896
Lines 43010 43024 +14
=======================================
+ Hits 42263 42281 +18
+ Misses 747 743 -4
Continue to review full report at Codecov.
|
marcotc
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The profiler supports reporting profiling data directly to the datadog backend, without having to go through an agent. This setup is actively discouraged by the profiling team for users, but hey, it is really handy for testing and prototyping.
But we don't want users to accidentally enable this mode. Up until now, profiler would implicitly use this mode if users set a
DD_API_KEYand aDD_SITEconfiguration. Now, this mode will only be enabled if aDD_PROFILING_AGENTLESSenvironment variable is set totrue.