Fix:Aws instrumentation patch without S3 #1592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotc
force-pushed
the
fix-aws-s3-patch
branch
2 times, most recently
from
b26cd82
to
7854f57
Compare
Codecov Report
@@ Coverage Diff @@
## master #1592 +/- ##
=======================================
Coverage 98.26% 98.26%
=======================================
Files 896 896
Lines 43010 43037 +27
=======================================
+ Hits 42263 42291 +28
+ Misses 747 746 -1
Continue to review full report at Codecov.
|
marcotc
force-pushed
the
fix-aws-s3-patch
branch
from
7854f57
to
72d640b
Compare
brettlangdon
approved these changes
Jul 13, 2021
marcotc
added a commit
that referenced
this pull request
Jul 13, 2021
marcotc
added a commit
that referenced
this pull request
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1589
This PR modifies the AWS instrumentation to only augment the
Aws::S3package if present.This issue was introduced in #1494, when presign S3 requests became excluded from network instrumentation in https://github.com/DataDog/dd-trace-rb/releases/tag/v0.51.0.