[PROF-3944] Change profiler to gather "local root span id" from active traces instead of "trace id" #1688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1688 +/- ##
=======================================
Coverage 98.17% 98.18%
=======================================
Files 934 934
Lines 45092 45122 +30
=======================================
+ Hits 44271 44301 +30
Misses 821 821
Continue to review full report at Codecov.
|
marcotc
reviewed
Sep 16, 2021
marcotc
approved these changes
Sep 16, 2021
delner
reviewed
Sep 17, 2021
ivoanjo
force-pushed
the
ivoanjo/profiler-track-local-root-span-id
branch
2 times, most recently
from
cef2d74
to
5d18d2e
Compare
marcotc
approved these changes
Oct 15, 2021
This method allows getting both the current span, as well as the root span with atomic semantics, to avoid data races.
…e traces instead of "trace id" The `trace id` that we gather today is not useful, because the backend ends up using the `runtime-id` and `span id` to get all information it needs. Gathering instead the `local root span id` will enable the profiler backend to optimize scoping profiles in the UX down to a single request (all spans that share the same local root span id).
Otherwise the previous benchmark dump was innacurate, since the resulting pprof no longer cared for the trace id that it included. I've renamed the benchmark to "profiler_submission_v2" to mark the change to the input data -- I've measured the performance of the benchmark to stay similar, but not the same [within ~10%], so it's relevant to mark this change.
ivoanjo
force-pushed
the
ivoanjo/profiler-track-local-root-span-id
branch
from
5d1035a
to
76414a5
Compare
|
Thanks Marco! I had to do one final rebase to fix a trivial conflict with #1718 , merging away now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
trace idthat we gather today is not useful, because the backend ends up using theruntime-idandspan idto get all information it needs.Gathering instead the
local root span idwill enable the profiler backend to optimize scoping profiles in the UX down to a single request (all spans that share the same local root span id).I've tested this both locally and on the reliability environment.