[PROF-4065] Rename extract_trace_resource to endpoint.collection.enabled
#1702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings this setting in line with the other profilers. We don't expect to impact users, since this feature is not available in the UX.
This can be used as an alternative to setting the `settings.profiling.advanced.endpoint.collection.enabled` setting. The previous default is still kept: this feature is ENABLED by default.
marcotc
approved these changes
Sep 28, 2021
ivoanjo
deleted the
ivoanjo/prof-4065-add-endpoint-collection-env-flag
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the profiling setting
profiling.advanced.extract_trace_resourcetoprofiling.advanced.endpoint.collection.enabledto match the name chosen for other languages.It also adds support for setting the same value via an environment variable --
DD_PROFILING_ENDPOINT_COLLECTION_ENABLED, which again is standard for Datadog profilers.This is not expected to affect users since this feature hasn't been yet exposed in the UX so it's not expected that users were already setting
extract_trace_resource.