[ci-visibility] Add test.framework_version Tag to rspec and cucumber
#1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juan-fernandez
force-pushed
the
juan-fernandez/ci-visibility-add-framework-version
branch
from
d72f5de
to
ac8193c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1713 +/- ##
=======================================
Coverage 98.17% 98.17%
=======================================
Files 934 934
Lines 45048 45057 +9
=======================================
+ Hits 44227 44236 +9
Misses 821 821
Continue to review full report at Codecov.
|
marcotc
reviewed
Oct 7, 2021
marcotc
reviewed
Oct 7, 2021
| @@ -39,6 +39,7 @@ def on_test_case_started(event) | |||
| service: configuration[:service_name] | |||
| }, | |||
| framework: Ext::FRAMEWORK, | |||
| framework_version: Gem.loaded_specs['cucumber'].version.to_s, | |||
There was a problem hiding this comment.
Same suggestion as the RSpec one below.
Co-authored-by: Marco Costa <marco.costa@datadoghq.com>
juan-fernandez
force-pushed
the
juan-fernandez/ci-visibility-add-framework-version
branch
from
7f42039
to
e212b3e
Compare
delner
approved these changes
Oct 8, 2021
juan-fernandez
deleted the
juan-fernandez/ci-visibility-add-framework-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps pinpoint issues with specific versions of the testing frameworks.