Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git branch not detected from Buildkite CI environment #1745

Closed
langsharpe opened this issue Oct 31, 2021 · 2 comments · Fixed by #1763
Closed

Git branch not detected from Buildkite CI environment #1745

langsharpe opened this issue Oct 31, 2021 · 2 comments · Fixed by #1763
Assignees
@juan-fernandez
Labels
bug Involves a bug ci-app CI product for test suite instrumentation community Was opened by a community member
Milestone
0.54.0

Comments

@langsharpe
Copy link

Buildkite always includes the BUILDKITE_TAG environment variable, causing the branch to be overwritten.

HEAD is the only branch reported
Screen Shot 2021-11-01 at 09 08 32

Buildkite environment including empty variables
CleanShot 2021-11-01 at 09 03 44

"".nil? is false, so the branch gets deleted

dd-trace-rb/lib/datadog/ci/ext/environment.rb

Line 48 in 735404e

tags.delete(Datadog::Ext::Git::TAG_BRANCH) unless tags[Datadog::Ext::Git::TAG_TAG].nil?

@delner delner added ci-app CI product for test suite instrumentation community Was opened by a community member bug Involves a bug labels Nov 1, 2021
@delner
Copy link
Contributor

delner commented Nov 2, 2021

I've forwarded this one to our CI team.

@fermayo fermayo mentioned this issue Nov 7, 2021
Merged
@marcotc marcotc added this to the 0.54.0 milestone Nov 17, 2021
@marcotc
Copy link
Member

marcotc commented Nov 18, 2021

👋 @langsharpe, https://github.com/DataDog/dd-trace-rb/releases/tag/v0.54.0 was just released, including a fix for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juan-fernandez juan-fernandez

Labels
bug Involves a bug ci-app CI product for test suite instrumentation community Was opened by a community member
Projects
None yet
Milestone
0.54.0
Development

Successfully merging a pull request may close this issue.

Update CI environment variables parsing DataDog/dd-trace-rb
4 participants
@langsharpe @marcotc @delner @juan-fernandez