Fix Grape raising error while tracing is disabled #1943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivoanjo
approved these changes
Mar 21, 2022
delner
force-pushed
the
fix/grape_resource_while_disabled
branch
from
f409c07
to
c3e2706
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1940
When tracing is disabled, the
enabled?function in Grape instrumentation was still evaluating to true, because it was only checking the Grape configuration setting. This would cause instrumentation to still run, but yield aniltrace and attempt to decorate it.Updating
enabled?to check for whethertracing.enabledis set fixes the issue.It would be better in the future if setting
c.tracing.enabledsimply precluded all instrumentation blocks, but our API currently doesn't support this. Thus, instrumentation must check the state itself. Something to improve another time.