Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix UpgradeGuide.md "agent.host" #1956

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

delner
Copy link
Contributor

@delner delner commented Mar 31, 2022

The upgrade guide was incorrectly recommending usage of agent.hostname when it should be recommending agent.host.

@delner delner added the docs Involves documentation label Mar 31, 2022
@delner delner added this to the 1.0.0.beta2 milestone Mar 31, 2022
@delner delner requested a review from a team March 31, 2022 18:23
@delner delner self-assigned this Mar 31, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1956 (3c54cfd) into master (027aa58) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1956      +/-   ##
==========================================
- Coverage   97.53%   97.53%   -0.01%     
==========================================
  Files         998      998              
  Lines       49006    49006              
==========================================
- Hits        47800    47799       -1     
- Misses       1206     1207       +1     
Impacted Files Coverage Δ
spec/datadog/profiling/ext/forking_spec.rb 99.38% <0.00%> (-0.62%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@delner delner force-pushed the docs/fix_upgrade_guide_hostname branch from 3c54cfd to 6912c01 Compare April 14, 2022 18:38
@delner delner added this to Reviewer approved in 1.0 Apr 14, 2022
@delner delner merged commit 8a75c8e into master Apr 14, 2022
@delner delner deleted the docs/fix_upgrade_guide_hostname branch April 14, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Involves documentation
Projects
1.0
Reviewer approved
Development

Successfully merging this pull request may close these issues.

None yet

3 participants