Review sampling docs for Ruby [v2] #1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivoanjo
reviewed
Apr 4, 2022
| @@ -2068,21 +2068,11 @@ Datadog.configure { |c| c.diagnostics.startup_logs.enabled = true } | |||
|
|
|||
| By default, this will be activated whenever `ddtrace` detects the application is running in a non-development environment. | |||
|
|
|||
| ### Sampling | |||
There was a problem hiding this comment.
I think we should keep this heading, as the two next sections (application-side sampling, priority sampling) are supposed to be under it.
There was a problem hiding this comment.
Added back 👍
Co-authored-by: Ivo Anjo <ivo.anjo@datadoghq.com>
Codecov Report
@@ Coverage Diff @@
## master #1958 +/- ##
=======================================
Coverage 97.53% 97.53%
=======================================
Files 998 998
Lines 49006 49006
=======================================
Hits 47800 47800
Misses 1206 1206 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Tracing without Limits occurrences from the Ruby tracer documentation