Hide symbols/functions in profiling native extension #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The native extension is not intended to expose any symbols/functions for other native libraries to use, so let's set the default visibility to hidden. This avoids accidental symbol naming clashes with other extensions/libraries. Test suite still green :)
luhenry
approved these changes
Apr 8, 2022
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| static VALUE native_working_p(VALUE self); | |||
|
|
|||
| void Init_ddtrace_profiling_native_extension(void) { | |||
| void __attribute__ ((visibility ("default"))) Init_ddtrace_profiling_native_extension(void) { | |||
There was a problem hiding this comment.
for conciseness I would have a #define EXPORT __attribute__ ((visibility ("default"))) somewhere (ir whatever fits better than EXPORT. Also, doesn't Ruby have such define for native extensions?
There was a problem hiding this comment.
Good question! There's a RUBY_FUNC_EXPORTED but only from Ruby 3.0 on 😭
Since there's no common header where to place it, for now I left a #define DDTRACE_EXPORT in profiling.c, will move it once there's other places where we want to use it.
For now `DDTRACE_EXPORT` will live in `profiling.c` because we don't yet have a shared generic header.
Codecov Report
@@ Coverage Diff @@
## master #1968 +/- ##
=======================================
Coverage 97.69% 97.69%
=======================================
Files 1000 1000
Lines 50445 50445
=======================================
+ Hits 49283 49284 +1
+ Misses 1162 1161 -1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The native extension is not intended to expose any symbols/functions for other native libraries to use, so let's set the default visibility to hidden.
This avoids accidental symbol naming clashes with other extensions/libraries.
Test suite still green :)