[PROF-6070] Remove legacy profiling transport #2062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivoanjo
commented
Jul 22, 2022
…p to `HttpTransport` class" This reverts commit 3b7126d. This has been replaced by the `HttpTransport` class, and was only left behind as a temporary backup in case there were any issues in `HttpTransport`.
…g/env variable" This reverts commit 09d83b3. This has been replaced by the `HttpTransport` class, and was only left behind as a temporary backup in case there were any issues in `HttpTransport`.
ivoanjo
force-pushed
the
ivoanjo/remove-legacy-profiling-transport
branch
from
6d66a36
to
b19b8fb
Compare
ivoanjo
changed the title
marcotc
approved these changes
Oct 3, 2022
|
Thanks Marco for the review! As discussed via slack, I'm going to hold off on merging this until next week :) |
Merged
ivoanjo
added a commit
that referenced
this pull request
Feb 16, 2023
**What does this PR do?**: This PR removes a `merge` method that is no longer in use. This is safe to remove because it is not part of ddtrace's public API. This was only used by the legacy profiling transport (as hinted in the comment attached to the code), and the legacy profiling transport was removed in #2062 (search for `configure_for_agent` inside `lib/datadog/profiling/transport/http.rb`). **Motivation**: Remove unused code :) **Additional Notes**: N/A **How to test the change?**: Check that CI is still green.
ivoanjo
added a commit
that referenced
this pull request
Feb 16, 2023
**What does this PR do?**: This PR removes a `merge` method that is no longer in use. This is safe to remove because it is not part of ddtrace's public API. This was only used by the legacy profiling transport (as hinted in the comment attached to the code), and the legacy profiling transport was removed in #2062 (search for `configure_for_agent` inside `lib/datadog/profiling/transport/http.rb`). **Motivation**: Remove unused code :) **Additional Notes**: N/A **How to test the change?**: Check that CI is still green.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2059 we changed the profiler to use the new
HttpTransportto report profiling data, but we left around the legacy transport code:The 1.2.0->1.5.0 releases have defaulted to use the new
Profiling::HttpTransport, and other than #2151/#2152 which was solved in 1.3.0, no other issues have been reported so I think we're ready to remove the old code.