Fix profiler not building on ruby-head (3.2) due to VM refactoring #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new `struct rb_native_thread` was introduced to contain the `thread_id`. Fixes #2065
The correct modern way to declare a function which takes no arguments is `void foo(void)` not `void foo()`.
4 tasks
Codecov Report
@@ Coverage Diff @@
## master #2066 +/- ##
=======================================
Coverage 97.49% 97.49%
=======================================
Files 1031 1031
Lines 53211 53213 +2
=======================================
+ Hits 51876 51880 +4
+ Misses 1335 1333 -2
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
TonyCTHsu
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new
struct rb_native_threadwas introduced to contain thethread_id(see ruby/ruby#5836) and thus we need to add a ifdef for Ruby 3.2.Fixes #2065
(Note: We don't yet have Ruby 3.2 in our CI setup, so you'll just have to take my word for it that this makes it compile now! Or try it locally on your own machine :P)