-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Utility to Collect Platform Information #2097
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make sure these methods only return not-nil when we are confident of the values.
For example, for JRuby, we should only return values if they reflect uname -foo
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one small comment left.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No small comments left.
* Add host information utility * fixup! Add host information utility * Rename file to platform * fixup! Rename file to platform * Require etc in file
Description
Added module to collect information on the platform that dd-trace is running on. This information will be used in telemetry API requests (payload spec can be found here).
Open Questions
os
andos_version
--theenvironment_logger.rb
file usesRbConfig
to get the os name (here). This doesn't match the value fromuname -o
exactly as it also includes architecture information (GNU/Linux
vs.aarch64-unknown-linux-gnu
); however, would it be better to send that value anyway rather than sending nothing?