Add internal tracing to Sidekiq / DelayedJob #2170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redis_info, scheduled_poller_wait, stop
idanci
reviewed
Aug 5, 2022
| require 'sidekiq/cli' | ||
|
|
||
| configure_sidekiq | ||
| # binding.pry |
There was a problem hiding this comment.
Thanks for pointing this out 😓 it has been removed now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds additional instrumentation to Sidekiq and DelayedJob to wraps spans from Redis/ActiveRecord to prevent them from appearing as top-level spans.
Motivation
Fixes #2056
Additional Notes
How to test the change?
Additional unit tests were added to verify the changes.