-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hanami 1.x instrumentation #2230
Conversation
Since this PR is already big as-is, here's a suggestion: consider doing a separate PR to just add Hanami as a test app (even if it doesn't work until we actually add the instrumentation). That way we can focus more on the actual changes and how instrumentation looks vs getting lost in the noise of bootstrapping an example Hanami application. 😄 |
f1d16df
to
fb49b6a
Compare
fb49b6a
to
7535492
Compare
7535492
to
0001de6
Compare
0001de6
to
a19e967
Compare
0a40546
to
3b62586
Compare
49767a9
to
6e8799f
Compare
6e8799f
to
1b1ae0e
Compare
Codecov Report
@@ Coverage Diff @@
## feature/hanami-integration-app #2230 +/- ##
=================================================================
Coverage ? 97.59%
=================================================================
Files ? 1106
Lines ? 57541
Branches ? 0
=================================================================
Hits ? 56156
Misses ? 1385
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 !
Setup Guide
Install
in
Gemfile
Configuration
in
config/initializers/datadog.rb
What does this Hanami instrumentation provide?
Instrument Hanami
1.x
, internally activating rack to instrumentrack
, which is usually the root span and could handle distributing tracing.3 spans are generated by a Hanami instrumentation, which are
routing
,action
,render
.routing
starts recording from endpoint lookup til the response is returnedaction
covers the time for an action execution, including callbacks such asbefore
andafter
render
describes the duration when an output is provided(from action or rack middleware) to be rendered.#979
The example flamegraph pattern looks like below