Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow DD_TAGS values to have the colon character #2292

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Sep 27, 2022

Colons are allowed in Datadog tags: they are considered part of the key's "value".

From: https://docs.datadoghq.com/getting_started/tagging/#define-tags

The key always precedes the first colon of the global tag definition, for example:

Tag Key Value
env:staging:east env staging:east

This PR allows for DD_TAGS to contain colons in the tag "value" component.

@marcotc marcotc added the bug Involves a bug label Sep 27, 2022
@marcotc marcotc self-assigned this Sep 27, 2022
@marcotc marcotc requested a review from a team September 27, 2022 16:50
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great, thanks for the fix!

@marcotc marcotc merged commit 6daebba into master Oct 3, 2022
@marcotc marcotc deleted the fix-tags-colon branch October 3, 2022 19:22
@github-actions github-actions bot added this to the 1.6.0 milestone Oct 3, 2022
@TonyCTHsu TonyCTHsu mentioned this pull request Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Involves a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants