Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL comment propagation for mysql2 #2324

Merged
merged 17 commits into from
Oct 31, 2022

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Oct 21, 2022

What does this PR do?

Inject sql comment to enable database monitoring.

By default, it is disabled.

With service mode, our tracer propagates service context to database, which enable Datadog to build service map.

@github-actions github-actions bot added core Involves Datadog core libraries integrations Involves tracing integrations tracing labels Oct 21, 2022
@github-actions github-actions bot removed the core Involves Datadog core libraries label Oct 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2022

Codecov Report

Merging #2324 (e64d994) into master (277f4bb) will increase coverage by 0.00%.
The diff coverage is 99.51%.

@@           Coverage Diff            @@
##           master    #2324    +/-   ##
========================================
  Coverage   98.30%   98.30%            
========================================
  Files        1092     1100     +8     
  Lines       58047    58242   +195     
========================================
+ Hits        57062    57256   +194     
- Misses        985      986     +1     
Impacted Files Coverage Δ
...tadog/tracing/contrib/sinatra/tracer_middleware.rb 94.73% <0.00%> (ø)
...g/tracing/contrib/mysql2/configuration/settings.rb 100.00% <100.00%> (ø)
.../datadog/tracing/contrib/mysql2/instrumentation.rb 100.00% <100.00%> (ø)
...datadog/tracing/contrib/propagation/sql_comment.rb 100.00% <100.00%> (ø)
...tracing/contrib/propagation/sql_comment/comment.rb 100.00% <100.00%> (ø)
...dog/tracing/contrib/propagation/sql_comment/ext.rb 100.00% <100.00%> (ø)
...og/tracing/contrib/propagation/sql_comment/mode.rb 100.00% <100.00%> (ø)
...pec/datadog/tracing/contrib/mysql2/patcher_spec.rb 100.00% <100.00%> (ø)
...ng/contrib/propagation/sql_comment/comment_spec.rb 100.00% <100.00%> (ø)
...acing/contrib/propagation/sql_comment/mode_spec.rb 100.00% <100.00%> (ø)
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@marcotc
Copy link
Member

marcotc commented Oct 27, 2022

Anything keeping this PR in draft state?

@TonyCTHsu
Copy link
Contributor Author

@marcotc I am still working on the documentation for this 😄

@TonyCTHsu TonyCTHsu changed the title SQL comment propagation SQL comment propagation for mysql2 Oct 27, 2022
@TonyCTHsu TonyCTHsu marked this pull request as ready for review October 28, 2022 10:44
@TonyCTHsu TonyCTHsu requested a review from a team October 28, 2022 10:44
@TonyCTHsu TonyCTHsu self-assigned this Oct 28, 2022
Copy link
Member

@marcotc marcotc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@TonyCTHsu TonyCTHsu merged commit 88a969f into master Oct 31, 2022
@TonyCTHsu TonyCTHsu deleted the feature/dbm-sql-comment-propagation branch October 31, 2022 11:30
@github-actions github-actions bot added this to the 1.6.0 milestone Oct 31, 2022
@TonyCTHsu TonyCTHsu mentioned this pull request Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants