Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL comment propagation for pg #2339

Merged
merged 10 commits into from
Oct 31, 2022

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Oct 27, 2022

What does this PR do?

Inject sql comment to enable database monitoring.

By default, it is disabled.

With service mode, our tracer propagates service context to database, which enable Datadog to build service map.

@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Oct 27, 2022
@TonyCTHsu TonyCTHsu force-pushed the feature/dbm-sql-comment-propagation-for-pg branch from 0ab46c2 to d36f022 Compare October 27, 2022 19:29
@TonyCTHsu TonyCTHsu force-pushed the feature/dbm-sql-comment-propagation-for-pg branch from d36f022 to 4c7b093 Compare October 27, 2022 19:53
@TonyCTHsu TonyCTHsu marked this pull request as ready for review October 28, 2022 11:47
@TonyCTHsu TonyCTHsu requested a review from a team October 28, 2022 11:47
@codecov-commenter
Copy link

Codecov Report

Merging #2339 (3a565a7) into feature/dbm-sql-comment-propagation (e64d994) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@                           Coverage Diff                           @@
##           feature/dbm-sql-comment-propagation    #2339      +/-   ##
=======================================================================
- Coverage                                98.30%   98.30%   -0.01%     
=======================================================================
  Files                                     1100     1100              
  Lines                                    58242    58283      +41     
=======================================================================
+ Hits                                     57256    57295      +39     
- Misses                                     986      988       +2     
Impacted Files Coverage Δ
...tadog/tracing/contrib/pg/configuration/settings.rb 100.00% <100.00%> (ø)
lib/datadog/tracing/contrib/pg/instrumentation.rb 100.00% <100.00%> (ø)
spec/datadog/tracing/contrib/pg/patcher_spec.rb 100.00% <100.00%> (ø)
...adog/tracing/contrib/sidekiq/client_tracer_spec.rb 97.91% <0.00%> (-2.09%) ⬇️
lib/datadog/core/diagnostics/environment_logger.rb 98.42% <0.00%> (-1.58%) ⬇️
...ng/contrib/active_support/cache/instrumentation.rb 87.58% <0.00%> (-0.09%) ⬇️
lib/datadog/core/workers/polling.rb 100.00% <0.00%> (+3.44%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@TonyCTHsu TonyCTHsu self-assigned this Oct 28, 2022
Base automatically changed from feature/dbm-sql-comment-propagation to master October 31, 2022 11:30
@TonyCTHsu TonyCTHsu merged commit 2b30f97 into master Oct 31, 2022
@TonyCTHsu TonyCTHsu deleted the feature/dbm-sql-comment-propagation-for-pg branch October 31, 2022 11:31
@github-actions github-actions bot added this to the 1.6.0 milestone Oct 31, 2022
@TonyCTHsu TonyCTHsu mentioned this pull request Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants