Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds span.kind as client for redis #2392

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Adds span.kind as client for redis #2392

merged 1 commit into from
Nov 22, 2022

Conversation

zarirhamza
Copy link
Contributor

What does this PR do?

Tags span.kind of redis as client, inspired by Opentelemetry

@zarirhamza zarirhamza requested a review from a team November 22, 2022 16:57
@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Nov 22, 2022
TonyCTHsu
TonyCTHsu approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@TonyCTHsu TonyCTHsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good job!

@TonyCTHsu TonyCTHsu merged commit f6d57ad into master Nov 22, 2022
@TonyCTHsu TonyCTHsu deleted the zarir/redis_span_kind_client branch November 22, 2022 20:55
@github-actions github-actions bot added this to the 1.7.0 milestone Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcotc marcotc marcotc approved these changes

@TonyCTHsu TonyCTHsu TonyCTHsu approved these changes

Assignees
No one assigned
Labels
integrations Involves tracing integrations tracing
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zarirhamza @marcotc @TonyCTHsu