Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds span.kind tag for que, shoryuken, sneakers, and resque #2394

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

zarirhamza
Copy link
Contributor

@zarirhamza zarirhamza commented Nov 22, 2022

What does this PR do?
Adds span.kind tag for integrations que, shoryuken, sneakers, and resque

Refer to Opentelemetry for definitions of consumer

These integrations uniquely only have consumer tags and the corresponding producer functions are not traced thus no span within the integration has an opposing producer tag.

que, shoryuken, and sneakers integrations have the span.kind tag set within the call function that runs jobs
resque has span.kind tag set within the perform function that runs jobs

@zarirhamza zarirhamza requested a review from a team November 22, 2022 18:00
@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Nov 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2022

Codecov Report

Merging #2394 (7699a18) into master (a6a1bc5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2394   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files        1102     1102           
  Lines       59374    59382    +8     
=======================================
+ Hits        58397    58405    +8     
  Misses        977      977           
Impacted Files Coverage Δ
lib/datadog/tracing/contrib/que/tracer.rb 96.96% <100.00%> (+0.09%) ⬆️
lib/datadog/tracing/contrib/resque/resque_job.rb 100.00% <100.00%> (ø)
lib/datadog/tracing/contrib/shoryuken/tracer.rb 100.00% <100.00%> (ø)
lib/datadog/tracing/contrib/sneakers/tracer.rb 100.00% <100.00%> (ø)
spec/datadog/tracing/contrib/que/tracer_spec.rb 100.00% <100.00%> (ø)
...dog/tracing/contrib/resque/instrumentation_spec.rb 100.00% <100.00%> (ø)
...c/datadog/tracing/contrib/shoryuken/tracer_spec.rb 100.00% <100.00%> (ø)
...ec/datadog/tracing/contrib/sneakers/tracer_spec.rb 100.00% <100.00%> (ø)
lib/datadog/core/diagnostics/environment_logger.rb 98.42% <0.00%> (-1.58%) ⬇️
...ng/contrib/active_support/cache/instrumentation.rb 87.58% <0.00%> (-0.09%) ⬇️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zarirhamza zarirhamza changed the title Adds span.kind tag for que, shoryuken, and sneakers Adds span.kind tag for que, shoryuken, sneakers, and resque Nov 22, 2022
@marcotc marcotc merged commit b866b25 into master Nov 22, 2022
@marcotc marcotc deleted the zarir/span_kind_consumer branch November 22, 2022 23:06
@github-actions github-actions bot added this to the 1.7.0 milestone Nov 22, 2022
@ivoanjo
Copy link
Member

ivoanjo commented Nov 30, 2022

Hey @zhamza99, all your awesome span.kind fixes were just released it as part of version 1.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants