Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds span.kind tag for racecar #2413

Merged
merged 4 commits into from
Nov 23, 2022
Merged

Adds span.kind tag for racecar #2413

merged 4 commits into from
Nov 23, 2022

Conversation

zarirhamza
Copy link
Contributor

What does this PR do?
Adds span.kind tag for integrations racecar

Refer to Opentelemetry for definitions of consumer

Racecar is only a kafka consumer library, so not possible to tag any spans created with producer from this integration

Note that there are changes made to the Appraisals file because the racecar installation for certain ruby versions was disabled. However, it seems the issue that was causing them to be disabled has been closed.

@zarirhamza zarirhamza requested a review from a team November 23, 2022 17:27
@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Nov 23, 2022
Appraisals Show resolved Hide resolved
Copy link
Member

@marcotc marcotc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for restoring racecar tests as well 🙏

@marcotc marcotc merged commit 17dd32c into master Nov 23, 2022
@marcotc marcotc deleted the zarir/span_kind_racecar branch November 23, 2022 22:18
@github-actions github-actions bot added this to the 1.7.0 milestone Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants