Move Tracing diagnostic code from Core to Tracing #2453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
added
core
marcotc
approved these changes
Dec 1, 2022
TonyCTHsu
approved these changes
Dec 2, 2022
delner
force-pushed
the
refactor/extract_tracing_diagnostics
branch
from
f1f65c5
to
f8e886d
Compare
Codecov Report
@@ Coverage Diff @@
## master #2453 +/- ##
==========================================
- Coverage 98.31% 98.30% -0.01%
==========================================
Files 1102 1104 +2
Lines 59010 59027 +17
==========================================
+ Hits 58013 58028 +15
- Misses 997 999 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves some Tracing specific configuration and diagnostics out of
Coreand toTracing.Motivation
The larger goal is to reduce
Core's knowledge ofTracingcomponents, thereby reducing coupling.This particular pull request does not fundamentally change the dependency of
CoreuponTracing, but it does at least move the code itself into the appropriate folder. The resulting changes exposes the dependency a bit more explicitly, and should make it easier to invert later.