Move Tracing config settings from Core to Tracing #2459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
added
core
marcotc
reviewed
Dec 3, 2022
Codecov Report
@@ Coverage Diff @@
## master #2459 +/- ##
=======================================
Coverage 98.02% 98.02%
=======================================
Files 1108 1110 +2
Lines 59756 59771 +15
=======================================
+ Hits 58576 58593 +17
+ Misses 1180 1178 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
delner
force-pushed
the
refactor/extract_tracing_config_settings
branch
from
f09b28c
to
dc759cd
Compare
marcotc
approved these changes
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves Tracing specific configuration out of Core and to Tracing.
Motivation
The larger goal is to reduce Core's knowledge of Tracing components, thereby reducing coupling.
This particular pull request does not fundamentally change the dependency of Core upon Tracing, but it does at least move the code itself into the appropriate folder. The resulting changes exposes the dependency a bit more explicitly, and should make it easier to invert later.
Additional Notes
The settings themselves did not change, despite the large line count.
settings :tracingmerely moved intotracing/configuration/settings.rbinstead. Consequently, so did the specs for these settings.It's worth noting that there's at least one lingering configuration setting
agent.tracer.port. This one likely constitutes a breaking change, but its ownership should also likely be moved toTracing. Left this alone for now.Follow up from #2453