SQL comment propagation full mode with traceparent #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyCTHsu
force-pushed
the
tonycthsu/sql-comment-propagation-full
branch
from
9e9e33b
to
8cd795c
Compare
delner
reviewed
Dec 5, 2022
| @@ -12,36 +14,30 @@ module SqlComment | |||
| def self.annotate!(span_op, mode) | |||
| return unless mode.enabled? | |||
|
|
|||
| # PENDING: Until `traceparent`` implementation in `full` mode | |||
| # span_op.set_tag(Ext::TAG_DBM_TRACE_INJECTED, true) if mode.full? | |||
| span_op.set_tag(Ext::TAG_DBM_TRACE_INJECTED, true) if mode.full? | |||
There was a problem hiding this comment.
The tag is defined to help filter for spans on the APM that have full trace context in their sql comment
marcotc
reviewed
Dec 5, 2022
Codecov Report
@@ Coverage Diff @@
## master #2464 +/- ##
==========================================
+ Coverage 98.01% 98.02% +0.01%
==========================================
Files 1105 1108 +3
Lines 59276 59772 +496
==========================================
+ Hits 58100 58593 +493
- Misses 1176 1179 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
marcotc
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implement SQL comment propagation with
fullmode, which includestraceparent