Add DD_TRACE_PROPAGATION_STYLE option #2466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotc
commented
Dec 6, 2022
| ENV_PROPAGATION_STYLE_EXTRACT = 'DD_TRACE_PROPAGATION_STYLE'.freeze | ||
| ENV_PROPAGATION_STYLE = 'DD_TRACE_PROPAGATION_STYLE'.freeze |
There was a problem hiding this comment.
I introduced this constant recently (a change still not released), but copy/pasted the constant name. This fixes that.
Codecov Report
@@ Coverage Diff @@
## master #2466 +/- ##
==========================================
+ Coverage 98.01% 98.03% +0.02%
==========================================
Files 1105 1111 +6
Lines 59276 59835 +559
==========================================
+ Hits 58100 58662 +562
+ Misses 1176 1173 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
TonyCTHsu
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR as a new propagation style configuration:
DD_TRACE_PROPAGATION_STYLE.This setting sets the value of both
tracing.distributed_tracing.propagation_extract_style&tracing.distributed_tracing.propagation_inject_styleto the provided value. This is meant to ease custom configuration where both injection and extraction have the same format, which is common.The existing options
DD_TRACE_PROPAGATION_STYLE_EXTRACT&DD_TRACE_PROPAGATION_STYLE_INJECThave higher priority than the newly introducedDD_TRACE_PROPAGATION_STYLE, allowing clients be more specific when needed without changing the generalDD_TRACE_PROPAGATION_STYLEsetting.