Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: ActionMailer instrumentation #250

Closed
webandtech opened this issue Nov 17, 2017 · 5 comments
Closed

Feature Request: ActionMailer instrumentation #250

webandtech opened this issue Nov 17, 2017 · 5 comments
Labels
community Was opened by a community member feature-request A request for a new feature or change to an existing one integrations Involves tracing integrations
Projects

Comments

@webandtech
Copy link

Would be interested in seeing metrics such as emails sent, errors, etc

@webandtech
Copy link
Author

webandtech commented Nov 20, 2017

I was able to get something like this going using an around_action in my base mailer. Could use some additional improvement then included in the base Rails instrumentation.

class ApplicationMailer < ActionMailer::Base
  around_action :datadog_trace

  def datadog_trace
    Datadog.tracer.trace('actionmailer.email') do |span|
      span.service = 'actionmailer'
      span.resource = "#{self.class.name}##{action_name}"
      yield
    end
  end
end

@palazzem palazzem added integrations Involves tracing integrations community Was opened by a community member labels Jan 10, 2018
@delner
Copy link
Contributor

delner commented Feb 7, 2018

Great suggestion, @webandtech ! This is on our radar; we'll take a deeper dive into it in the coming weeks. I'll keep you posted!

@delner delner added the feature-request A request for a new feature or change to an existing one label Sep 20, 2018
@dasch
Copy link
Contributor

dasch commented Oct 17, 2018

Any update on this?

@delner
Copy link
Contributor

delner commented Oct 17, 2018

This is on our backlog, but we have particular interest in instrumenting more Rails packages out-of-the-box, so I anticipate this one will be handled sooner rather than later.

@delner delner added this to Needs triage in Planning via automation Apr 15, 2021
@delner delner moved this from Needs triage to Long Term Priority in Planning Apr 15, 2021
@ivoanjo
Copy link
Member

ivoanjo commented Jul 13, 2022

This was added in #1280 but we totally forgot to close the issue, oops! I'm going to go ahead and close this, please do reach out to us if we can help in any way :)

@ivoanjo ivoanjo closed this as completed Jul 13, 2022
Planning automation moved this from Long Term Priority to Resolved (without changes) Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Was opened by a community member feature-request A request for a new feature or change to an existing one integrations Involves tracing integrations
Projects
Planning
Resolved (without changes)
Development

No branches or pull requests

5 participants