-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci visibility] Fix copy-paste error in teamcity env vars #2562
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM. Is this checked in system-tests or elsewhere? It looks like it'd be good to have test coverage for it :)
P.s.: We're working on fixing the unrelated CI hiccup, we should have it back to green soon and then I'll merge in the PR :) |
We have a separate repo (not linking it here because it is private) with tests that run against all tracers (since the behaviour should be the same for all). We don't have tests for TeamCity yet but I will add them today. |
Codecov Report
@@ Coverage Diff @@
## master #2562 +/- ##
==========================================
- Coverage 98.03% 98.02% -0.01%
==========================================
Files 1124 1124
Lines 60656 60683 +27
Branches 2767 2767
==========================================
+ Hits 59463 59487 +24
- Misses 1193 1196 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I've merged in the master branch to fix CI, making this good to go -- pressing the magic button now! |
What does this PR do?
Fixes a copy-paste error where the wrong env var was being used to compute the pipeline URL for TeamCity.